fix(migrations): Fix wiring secondarySqlStorage service bean #1525
+657
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radu-dragon
approved these changes
Jan 23, 2025
front50-sql/src/main/kotlin/com/netflix/spinnaker/config/SqlConfiguration.kt
Show resolved
Hide resolved
|
Wondering if we couldn't get a spring test to verify this functionality as well - to make sure we're able to load this! |
christosarvanitis
force-pushed
the
fix/compositeSQLrepository
branch
from
5055524 to
5e2d571
Compare
christosarvanitis
force-pushed
the
fix/compositeSQLrepository
branch
2 times, most recently
from
06c94c0 to
7f316b0
Compare
jasonmcintosh
approved these changes
Feb 3, 2025
|
Need to get tests more stable, but I think this looks good. Re-review once tests are adjusted to handle startup latency time. |
christosarvanitis
force-pushed
the
fix/compositeSQLrepository
branch
from
eece2ef to
74e7a8b
Compare
@jasonmcintosh pushed some stability changes to the integration tests. Feel free to merge if you are ok with the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wiring of the secondarySqlStorageService to allow SQL to SQL migrations using the CompositeStorageService
The secondaryJooq is only created when different dialect exists between the default and secondary connection pool which is not the case for Front50 migration between two SQL persistent stores