Swift: Fix for @ProtoDefaulted #2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lickel
force-pushed
the
ergonomics-fix
branch
from
fcabc25 to
e0dd0b2
Compare
lickel
commented
Nov 13, 2023
| import XCTest | ||
| @testable import Wire | ||
|
|
||
| final class ProtoEnumTests: XCTestCase { |
There was a problem hiding this comment.
These are new tests for other work that happened in v4.9.2.
dnkoutso
reviewed
Nov 14, 2023
| @@ -186,7 +186,8 @@ class SwiftGenerator private constructor( | |||
| if (type == ProtoType.ANY) return false | |||
| if (isMessage) { | |||
| val messageType = schema.getType(type!!) as MessageType | |||
| return messageType.supportsEmptyInitialization | |||
|
|
|||
| return messageType.supportsEmptyInitialization && messageType.fields.isNotEmpty() | |||
There was a problem hiding this comment.
This is the actual fix/change. I believe it is the correct fix overall if for any reason we cannot load the fields of a message we do not know whether we can provide a default value for it.
oldergod
approved these changes
Nov 14, 2023
dnkoutso
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Across module boundaries,
Message.fieldsis often (always?) empty. When that happens, we can't correctly know that we want@ProtoDefaultedor not. Given it's unknowable in the current context, it chooses not to emit them.