feat(native): Add toBeDisabled #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suany0805
force-pushed
the
feat/native-to-be-disabled
branch
from
c61ba82 to
190ce45
Compare
suany0805
force-pushed
the
feat/native-to-be-disabled
branch
from
4c514fe to
2259962
Compare
suany0805
force-pushed
the
feat/native-to-be-disabled
branch
from
2259962 to
72efbf8
Compare
suany0805
force-pushed
the
feat/native-to-be-disabled
branch
from
5817dc1 to
1e2a9c3
Compare
suany0805
force-pushed
the
feat/native-to-be-disabled
branch
from
1e2a9c3 to
5fbe42a
Compare
Co-Authored-By: Suany Chalan <79164262+suany0805@users.noreply.github.com>
JoseLion
changed the title
JoseLion
reviewed
Dec 16, 2024
| return "null"; | ||
| } | ||
|
|
||
| return `<${this.actual.type.toString()} testID="${this.actual.props.testID}"... />`; |
There was a problem hiding this comment.
Are we sure about this? Not all elements will have a testID. Also, using the testID should be our last resource when using tools like testing-library.
There was a problem hiding this comment.
We're missing tests for .not.toBeDisabled() and not.ToBeEnabled(). The messaging is different, so having some unit tests is good. I'd test them together with the not inverted test cases to make things simpler, check the core package for examples 🙂
…of main assertive path
suany0805
force-pushed
the
feat/native-to-be-disabled
branch
from
0022d85 to
898721a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.