Correct parsing of arrays and byte arrays #47

mat-kie · 2025-01-04T12:26:47Z

Related to #46

Behavioral Changes

Fix return type for Value::Byte in data_field_value
avoid vector re allocations during parsing
~~add checks to ensure a Value::Array is only valid if all entries share the same discriminant (or are set to Invalid)~~
add test cases for Byte array parsing
add tests for is_valid check

…ering discriminants

fitparser/src/de/parser.rs

… of differing discriminants" This reverts commit 4fb4407.

stadelmanma · 2025-01-07T01:51:22Z

Looks great, thank you for this!

mat-kie added 8 commits January 4, 2025 12:56

propose discriminant check. Array should never contain values of diff…

4fb4407

…ering discriminants

avoid unnececarry reallocations during parsing

873a13c

fix wrong Return type

9fdfe24

Ensure byte arrays are valid as soon a s a single byte is valid

76f73bf

address clippy warnings

33e7ab7

avoid multiple reallocations

b29af07

add test for discriminant check, fix bug if first value is invalid

28908c2

add missing test case for Invalid as first variant

45315b6

stadelmanma reviewed Jan 6, 2025

View reviewed changes

fitparser/src/de/parser.rs Outdated Show resolved Hide resolved

This was referenced Jan 6, 2025

Implement handling of invalid values in arrays #46

Closed

Support writing FIT files #33

Open

Revert "propose discriminant check. Array should never contain values…

2ead350

… of differing discriminants" This reverts commit 4fb4407.

mat-kie force-pushed the improve-array-handling branch from fa0ba54 to 2ead350 Compare January 6, 2025 07:23

stadelmanma merged commit b4f4eda into stadelmanma:improve-array-handling Jan 7, 2025