Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: update client info #199

Merged
merged 117 commits into from
Oct 15, 2024
Merged

main: update client info #199

merged 117 commits into from
Oct 15, 2024

Conversation

carmichaelong
Copy link
Contributor

Supersedes #198. Points to AWS main image, and added some extra commenting.

@carmichaelong
Copy link
Contributor Author

Issue opened in #200 for further changes to clean up the docker build workflow

Copy link
Collaborator

@antoinefalisse antoinefalisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbertoCasasOrtiz
Copy link
Collaborator

If this is good feel free to merge! It should automatically update the AWS machine, right?

@antoinefalisse
Copy link
Collaborator

No, you still need to re-launch (make run only if on main branch and pulling images from ECR; make and then make run if building images locally).

@carmichaelong carmichaelong merged commit 1cd782a into main Oct 15, 2024
@carmichaelong carmichaelong deleted the main-client-info branch October 15, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants