Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: cleanup wallet activity code #6168

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

dlipicar
Copy link
Contributor

@dlipicar dlipicar commented Dec 4, 2024

Part 1 of many

Removed unused wallet API endpoints and associated code

@status-im-auto
Copy link
Member

status-im-auto commented Dec 4, 2024

Jenkins Builds

Click to see older builds (60)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bc5fa87 #1 2024-12-04 21:55:29 ~4 min macos 📦zip
✔️ bc5fa87 #1 2024-12-04 21:56:51 ~5 min ios 📦zip
✔️ bc5fa87 #1 2024-12-04 21:56:53 ~5 min macos 📦zip
✔️ bc5fa87 #1 2024-12-04 21:56:59 ~5 min windows 📦zip
✔️ bc5fa87 #1 2024-12-04 21:57:17 ~6 min android 📦aar
✔️ bc5fa87 #1 2024-12-04 21:58:06 ~6 min linux 📦zip
✔️ bc5fa87 #1 2024-12-04 21:58:35 ~7 min tests-rpc 📄log
✖️ bc5fa87 #1 2024-12-04 22:22:00 ~30 min tests 📄log
✔️ 00a5c59 #2 2024-12-09 12:26:01 ~3 min ios 📦zip
✔️ 00a5c59 #2 2024-12-09 12:27:16 ~5 min macos 📦zip
✔️ 00a5c59 #2 2024-12-09 12:27:27 ~5 min linux 📦zip
✔️ 00a5c59 #2 2024-12-09 12:28:00 ~5 min android 📦aar
✔️ 00a5c59 #2 2024-12-09 12:31:19 ~9 min macos 📦zip
✔️ 7b80b62 #3 2024-12-09 12:27:37 ~5 min windows 📦zip
✖️ 7b80b62 #3 2024-12-09 12:28:52 ~6 min tests-rpc 📄log
✔️ 7b80b62 #3 2024-12-09 12:29:59 ~3 min ios 📦zip
✔️ 7b80b62 #3 2024-12-09 12:32:42 ~5 min macos 📦zip
✔️ 7b80b62 #3 2024-12-09 12:32:57 ~5 min linux 📦zip
✔️ 7b80b62 #3 2024-12-09 12:34:15 ~6 min android 📦aar
✔️ 7b80b62 #3 2024-12-09 12:40:00 ~8 min macos 📦zip
✖️ 7b80b62 #3 2024-12-09 12:53:06 ~30 min tests 📄log
✔️ 8bfbc5e #4 2024-12-09 13:41:37 ~3 min windows 📦zip
✔️ 8bfbc5e #4 2024-12-09 13:42:11 ~4 min ios 📦zip
✔️ 8bfbc5e #4 2024-12-09 13:42:18 ~4 min linux 📦zip
✔️ 8bfbc5e #4 2024-12-09 13:42:23 ~4 min macos 📦zip
✔️ 8bfbc5e #4 2024-12-09 13:43:06 ~5 min macos 📦zip
✔️ 8bfbc5e #4 2024-12-09 13:43:17 ~5 min android 📦aar
✖️ 8bfbc5e #4 2024-12-09 13:43:43 ~5 min tests-rpc 📄log
✖️ 8bfbc5e #4 2024-12-09 14:06:57 ~29 min tests 📄log
✔️ 7f145f0 #5 2024-12-09 14:29:25 ~4 min windows 📦zip
✔️ 7f145f0 #5 2024-12-09 14:30:20 ~5 min macos 📦zip
✔️ 7f145f0 #5 2024-12-09 14:30:45 ~5 min linux 📦zip
✖️ 7f145f0 #5 2024-12-09 14:31:20 ~6 min tests-rpc 📄log
✔️ 7f145f0 #5 2024-12-09 14:31:26 ~6 min ios 📦zip
✔️ 7f145f0 #5 2024-12-09 14:32:17 ~7 min android 📦aar
✔️ 7f145f0 #5 2024-12-09 14:33:47 ~8 min macos 📦zip
✖️ 7f145f0 #5 2024-12-09 14:55:33 ~30 min tests 📄log
✖️ 8837789 #6 2025-01-07 18:48:22 ~3 min tests-rpc 📄log
✔️ 8837789 #6 2025-01-07 18:48:37 ~4 min macos 📦zip
✔️ 8837789 #6 2025-01-07 18:49:03 ~4 min ios 📦zip
✔️ 8837789 #6 2025-01-07 18:49:04 ~4 min linux 📦zip
✔️ 8837789 #6 2025-01-07 18:49:57 ~5 min windows 📦zip
✔️ 8837789 #6 2025-01-07 18:50:12 ~5 min macos 📦zip
✔️ 8837789 #6 2025-01-07 18:50:34 ~6 min android 📦aar
✖️ 8837789 #6 2025-01-07 19:15:09 ~30 min tests 📄log
✖️ b684c7d #7 2025-01-07 19:12:35 ~3 min tests-rpc 📄log
✔️ b684c7d #7 2025-01-07 19:13:12 ~3 min macos 📦zip
✔️ b684c7d #7 2025-01-07 19:13:19 ~3 min windows 📦zip
✔️ b684c7d #7 2025-01-07 19:13:43 ~4 min ios 📦zip
✔️ b684c7d #7 2025-01-07 19:13:49 ~4 min linux 📦zip
✔️ b684c7d #7 2025-01-07 19:14:37 ~5 min macos 📦zip
✔️ b684c7d #7 2025-01-07 19:14:44 ~5 min android 📦aar
✖️ b684c7d #7 2025-01-07 19:45:32 ~30 min tests 📄log
✔️ b1529bd #8 2025-01-07 19:23:15 ~3 min macos 📦zip
✔️ b1529bd #8 2025-01-07 19:23:20 ~3 min ios 📦zip
✔️ b1529bd #8 2025-01-07 19:23:20 ~3 min windows 📦zip
✔️ b1529bd #8 2025-01-07 19:24:27 ~5 min android 📦aar
✔️ b1529bd #8 2025-01-07 19:24:44 ~5 min macos 📦zip
✔️ b1529bd #8 2025-01-07 19:24:52 ~5 min linux 📦zip
✖️ b1529bd #8 2025-01-07 19:24:59 ~5 min tests-rpc 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0ca933f #9 2025-01-07 19:28:47 ~3 min macos 📦zip
✔️ 0ca933f #9 2025-01-07 19:28:57 ~4 min ios 📦zip
✔️ 0ca933f #9 2025-01-07 19:28:57 ~3 min windows 📦zip
✔️ 0ca933f #9 2025-01-07 19:30:04 ~5 min linux 📦zip
✔️ 0ca933f #9 2025-01-07 19:30:11 ~5 min android 📦aar
✔️ 0ca933f #9 2025-01-07 19:30:17 ~5 min macos 📦zip
✖️ 0ca933f #9 2025-01-07 19:30:38 ~5 min tests-rpc 📄log
✖️ 0ca933f #8 2025-01-07 20:16:12 ~30 min tests 📄log
✔️ 357d0fc #10 2025-01-09 18:28:32 ~3 min macos 📦zip
✔️ 357d0fc #10 2025-01-09 18:28:52 ~4 min ios 📦zip
✔️ 357d0fc #10 2025-01-09 18:28:57 ~4 min windows 📦zip
✔️ 357d0fc #10 2025-01-09 18:29:46 ~5 min linux 📦zip
✔️ 357d0fc #10 2025-01-09 18:30:07 ~5 min android 📦aar
✔️ 357d0fc #10 2025-01-09 18:30:12 ~5 min macos 📦zip
✖️ 357d0fc #10 2025-01-09 18:31:23 ~6 min tests-rpc 📄log
✖️ 357d0fc #9 2025-01-09 18:54:55 ~30 min tests 📄log

@dlipicar dlipicar force-pushed the chore/cleanup-deprecated-activity-code branch from 00a5c59 to 7b80b62 Compare December 9, 2024 12:22
@dlipicar dlipicar changed the title chore_: asdasdasd chore_: cleanup wallet activity code Dec 9, 2024
@dlipicar dlipicar changed the title chore_: cleanup wallet activity code (WIP) chore_: cleanup wallet activity code Dec 9, 2024
@dlipicar dlipicar force-pushed the chore/cleanup-deprecated-activity-code branch 2 times, most recently from 8bfbc5e to 7f145f0 Compare December 9, 2024 14:24
@dlipicar dlipicar force-pushed the chore/cleanup-deprecated-activity-code branch 2 times, most recently from 8837789 to b684c7d Compare January 7, 2025 19:09
@dlipicar dlipicar changed the title (WIP) chore_: cleanup wallet activity code chore_: cleanup wallet activity code Jan 7, 2025
@dlipicar dlipicar force-pushed the chore/cleanup-deprecated-activity-code branch 2 times, most recently from b1529bd to 0ca933f Compare January 7, 2025 19:24
@dlipicar dlipicar force-pushed the chore/cleanup-deprecated-activity-code branch from 0ca933f to 357d0fc Compare January 9, 2025 18:24
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 20.53%. Comparing base (73aadcb) to head (357d0fc).

Files with missing lines Patch % Lines
services/wallet/activity/session_service.go 0.00% 4 Missing ⚠️
services/local-notifications/database.go 50.00% 2 Missing ⚠️
services/wallet/routeexecution/manager.go 0.00% 2 Missing ⚠️
services/wallet/transfer/commands_sequential.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (73aadcb) and HEAD (357d0fc). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (73aadcb) HEAD (357d0fc)
unit 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6168       +/-   ##
============================================
- Coverage    53.25%   20.53%   -32.72%     
============================================
  Files          835      810       -25     
  Lines       134310   107262    -27048     
============================================
- Hits         71522    22023    -49499     
- Misses       54873    82162    +27289     
+ Partials      7915     3077     -4838     
Flag Coverage Δ
functional 20.53% <40.00%> (+0.03%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
node/status_node_services.go 60.28% <100.00%> (-7.15%) ⬇️
services/local-notifications/api.go 50.00% <ø> (+34.61%) ⬆️
services/local-notifications/core.go 92.59% <100.00%> (+3.70%) ⬆️
services/wallet/activity/service.go 6.56% <ø> (-46.97%) ⬇️
services/wallet/api.go 10.92% <ø> (-16.28%) ⬇️
services/wallet/transfer/block_dao.go 0.00% <ø> (-38.44%) ⬇️
services/wallet/transfer/controller.go 37.20% <ø> (-3.30%) ⬇️
services/wallet/transfer/database.go 2.49% <ø> (-53.93%) ⬇️
services/wallet/transfer/downloader.go 0.00% <ø> (-28.12%) ⬇️
services/wallet/transfer/helpers.go 1.66% <ø> (-51.55%) ⬇️
... and 7 more

... and 765 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants