list-item suppliment/fixes #8912
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (36)
|
|
|
@bitsikka could you resolve conflicts please, i've made some fixes and changes in list-item, removed blue theme and fixed container styles, please tell if you need any help with that, thanks |
@flexsurfer Also I noted that :blue theme related stuff is not completely removed, which I would clean-up if I could get dev build running on emulator. So, I'm kind of waiting for flurry of changes in the pipeline 👍 🚀 , hoping that will fix the build problem 😄 |
|
I'm pushing it anyway.. without clean-up to remeaining |
|
@bitsikka is it ready for testing? |
@flexsurfer |
|
@bitsikka please rebase, should be fixed now |
👍 Thanks! life saver :) |
One more thing I need a decision on:
I can think of 1 instance where this should keep the |
Yes we can! in design it's easy enough to override and on occasions we did just that like you pointed out in profiles. I imagine if possible, it would be nice to default to chevron as it's the vast majority of our use cases.
I think we can agree on all of them being 40% dark grey, yes. Regular dark grey is too much for something as secondary. edit: so to sum up, in the component you can customise which icon is used in the right side accessory, the appearance is unified at 40% dark grey like we use for chevrons currently. |
Cool! this will help keep yes |
|
I'm going to do this #8955 (comment) for |
Did this (works pretty good - in line with updated spec): [list-item/list-item
{:type :small
:accessibility-label :node-version
:title-prefix :t/node-version
:title
[react/text
{:number-of-lines 1
:ellipsize-mode :middle
:style
{:color colors/gray
:padding-left 16
:text-align :right
:line-height 22}}
node-version]}]Kept 62% of device width limit on For list-items with long accessories, better to hack fin :) |
|
@flexsurfer @yenda please let me know when this one will be ready for testing |
|
@bitsikka is it ready? |
|
93% of end-end tests have passedFailed tests (3)Click to expand
Passed tests (43)Click to expand |
|
Sorry, didn't post any testing notes Testing notes
|
100% of end-end tests have passedPassed tests (1) |
|
awesome work! |
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
In kind of a response to this comment by @errorists #8070 (comment)
fixes/adds these:
titlebeing squished by looong text accessory - it happens in profile>sync settings>mailserver list-item(some of the mailserver names are quite long). I think it is a good idea to limit in general, the length of text-accessory(about 2/3 of device width seems to work best).Note: there has always been an option for using component accessory for cases when longer than 2/3 accessory is needed - like transaction signing bottom-pop-up for example
react-keykey - useful for homogeneous list-items likechat-list/asset-list/list-with-radio-buttonsetc. Default key generated by handygensymCLJS core utility.:selectable:themetogether with:selected?config key for list-items with radio accessorylist-item/dividerwithinlist-itemby having atypecalleddividerStatus: ready