Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group role mapping #306

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add group role mapping #306

wants to merge 9 commits into from

Conversation

DavidFair
Copy link
Collaborator

@DavidFair DavidFair commented Jan 31, 2025

Description:

  • Adds assign group to an existing project
  • Adds the steps to add a user to a project

Testing

Special Notes:


Submitter:

Have you (where applicable):

  • Added unit tests?
  • Checked the latest commit runs on Dev?
  • Updated the example config file(s) and README?

Reviewer

Does this PR:

  • Place non-StackStorm code into the lib directory?
  • Have unit tests for the action/sensor and lib layers?
  • Have clear and obvious action parameter names and descriptions?

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (61479cf) to head (200b4f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   98.19%   98.21%   +0.01%     
==========================================
  Files         128      128              
  Lines        4718     4768      +50     
  Branches      251      251              
==========================================
+ Hits         4633     4683      +50     
  Misses         76       76              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Renames the action to add a user with a role to a project, so it's clear
which handles a group too
Adds an action to map an existing group to a project, which will be used
in the next step: adding users to that group
@DavidFair DavidFair force-pushed the Add_group_role_mapping branch from 4e84992 to bbbc85a Compare January 31, 2025 15:11
Adds the implementation to add a user to an existing group
Adds another variation of venv to the gitignore file
As the imported name doesn't match we don't need the extra specifier of
the upstream imported module, unlike the others.
This was masking the action name due to a copy-paste error
@DavidFair DavidFair force-pushed the Add_group_role_mapping branch from fdb6946 to 6f71772 Compare January 31, 2025 16:09
A cross-domain is disallowed by OpenStack, so simplify the action to
enforce this constraint in a user friendly way
Another action with a shadowing name where it was copied from an earlier
action
Since we no longer make multiple calls we don't need both calls from
unit testing anymore
@DavidFair DavidFair force-pushed the Add_group_role_mapping branch from b653fbf to 200b4f9 Compare January 31, 2025 16:26
@DavidFair DavidFair marked this pull request as ready for review January 31, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant