chore: phpstan fixes

storyblok · Jan 27, 2025 · e60b104 · e60b104
1 parent 464198d
commit e60b104
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 11 deletions.
diff --git a/src/Endpoints/StoryApi.php b/src/Endpoints/StoryApi.php
@@ -29,12 +29,12 @@ class StoryApi extends EndpointSpace
     private LoggerInterface $logger;
 
     /**
-    * StoryApi constructor.
-    *
-    * @param HttpClientInterface $httpClient
-    * @param string|int $spaceId
-    * @param LoggerInterface|null $logger Optional logger, defaults to NullLogger if not provided
-    */
+     * StoryApi constructor.
+     *
+     * @param HttpClientInterface $httpClient
+     * @param string|int $spaceId
+     * @param LoggerInterface $logger
+     */
     public function __construct(
         HttpClientInterface $httpClient,
         string|int $spaceId,
@@ -234,13 +234,14 @@ private function handleRateLimit(): void
      * Extracts stories from the API response
      *
      * @param StoryblokResponseInterface $response
-     * @return \Generator<StoryData>
+     * @return \Generator<int, StoryData>
      */
     private function getStoriesFromResponse(StoryblokResponseInterface $response): \Generator
     {
         /** @var StoriesData $stories */
         $stories = $response->data();
         foreach ($stories as $story) {
+            /** @var StoryData $story */
             yield $story;
         }
     }
@@ -250,7 +251,7 @@ private function getStoriesFromResponse(StoryblokResponseInterface $response): \
      *
      * @param int $page
      * @param int $perPage
-     * @throws InvalidArgumentException
+     * @throws \InvalidArgumentException
      */
     private function validatePaginationParams(int $page, int $perPage): void
     {
@@ -266,7 +267,7 @@ private function validatePaginationParams(int $page, int $perPage): void
      * Validates story ID
      *
      * @param string $storyId
-     * @throws InvalidArgumentException
+     * @throws \InvalidArgumentException
      */
     private function validateStoryId(string $storyId): void
     {

diff --git a/src/MapiClient.php b/src/MapiClient.php
@@ -89,9 +89,13 @@ public function spaceApi(): SpaceApi
      * @param LoggerInterface|null $logger
      * @return StoryApi
      */
-    public function storyApi(string|int $spaceId, ?LoggerInterface $logger = new NullLogger()): StoryApi
+    public function storyApi(string|int $spaceId, ?LoggerInterface $logger = null): StoryApi
     {
-        return new StoryApi($this->httpClient, $spaceId, $logger);
+        return new StoryApi(
+            $this->httpClient,
+            $spaceId,
+            $logger ?? new NullLogger(),
+        );
     }
 
     public function userApi(): UserApi