Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(StoryApi): improve story creation and error handling #2

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

edodusi
Copy link
Contributor

@edodusi edodusi commented Jan 27, 2025

  • fix: encode story data as JSON in POST/PUT requests
  • refactor: reorganize methods and improve code structure
  • feat: add optional logging capabilities

This fixes an issue with creating Stories with tags because of the encoding of the payload. Also I refactored the code for readability and maintainability and added an optional Logger.

- fix: encode story data as JSON in POST/PUT requests
- refactor: reorganize methods and improve code structure
- feat: add optional logging capabilities
- feat: add input validation methods
- feat: make logger dependency optional
@edodusi edodusi requested a review from roberto-butti January 27, 2025 16:34
@edodusi edodusi force-pushed the feat/encode_story_params branch from f784e4f to 0f891af Compare January 28, 2025 10:24
@roberto-butti roberto-butti merged commit 2a4838e into main Jan 28, 2025
2 checks passed
@roberto-butti roberto-butti deleted the feat/encode_story_params branch January 28, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants