Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: upgrade to storybook 7 #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ndelangen
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for sb-react-inspector ready!

Name Link
🔨 Latest commit 8792df9
🔍 Latest deploy log https://app.netlify.com/sites/sb-react-inspector/deploys/647f48841c20a3000828458b
😎 Deploy Preview https://deploy-preview-175--sb-react-inspector.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Bin script confusion @storybook/cli 7.0.18
  • Bin Script: sb
package.json via storybook@7.0.18
Shell access @storybook/cli 7.0.18 package.json via storybook@7.0.18
Bin script confusion storybook 7.0.18
  • Bin Script: sb
package.json
New author react-refresh 0.14.0 package.json via @storybook/react-vite@7.0.18
New author supports-hyperlinks 2.3.0 package.json via jest@26.6.3
New author puppeteer-core 2.1.1 package.json via storybook@7.0.18
Shell access puppeteer-core 2.1.1 package.json via storybook@7.0.18
Uses eval puppeteer-core 2.1.1 package.json via storybook@7.0.18
New author for-each 0.3.3 package.json via @storybook/react-vite@7.0.18, chromatic@6.18.0, storybook@7.0.18
New author fb-watchman 2.0.2 package.json via jest@26.6.3
New author defaults 1.0.4 package.json via storybook@7.0.18
New author anymatch 3.1.3 package.json via @storybook/react-vite@7.0.18, jest@26.6.3, tsup@6.7.0
New author querystringify 2.2.0 package.json via jest@26.6.3
New author assert 2.0.0 package.json via @storybook/react-vite@7.0.18, chromatic@6.18.0, storybook@7.0.18
New author fd-slicer 1.1.0 package.json via storybook@7.0.18
New author cacheable-request 7.0.2 package.json via chromatic@6.18.0
New author fast-diff 1.3.0 package.json via eslint-plugin-prettier@4.2.1
New author clone-response 1.0.3 package.json via chromatic@6.18.0
New author responselike 2.0.1 package.json via chromatic@6.18.0
New author write-file-atomic 2.4.3 package.json via storybook@7.0.18
Shell access @aw-web-design/x-default-browser 1.4.88 package.json via storybook@7.0.18
Shell access envinfo 7.8.1 package.json via storybook@7.0.18
Uses eval envinfo 7.8.1 package.json via storybook@7.0.18
Shell access jake 10.8.7 package.json via storybook@7.0.18
Shell access jscodeshift 0.14.0 package.json via storybook@7.0.18
Shell access shelljs 0.8.5 package.json via storybook@7.0.18
Shell access vite 4.3.9 package.json via @storybook/react-vite@7.0.18
Uses eval vite 4.3.9 package.json via @storybook/react-vite@7.0.18
Uses eval @snyk/graphlib 2.1.9-patch.3 package.json via chromatic@6.18.0
Uses eval @storybook/manager 7.0.18 package.json via storybook@7.0.18
Uses eval @storybook/preview 7.0.18 package.json via @storybook/react-vite@7.0.18
Uses eval @yarnpkg/lockfile 1.1.0
  • Eval Type: Function
  • Location: index.js
package.json via chromatic@6.18.0
Uses eval ejs 3.1.9 package.json via storybook@7.0.18
Uses eval esbuild-register 3.4.2 package.json via @storybook/react@7.0.18, @storybook/react-vite@7.0.18, storybook@7.0.18
Uses eval is-generator-function 1.0.10
  • Eval Type: Function
  • Location: index.js
package.json via @storybook/react-vite@7.0.18, chromatic@6.18.0, storybook@7.0.18
Uses eval prettier 2.8.8
  • Eval Type: Function
  • Location: cli.js
package.json via eslint-plugin-prettier@4.2.1, storybook@7.0.18
Uses eval promise 7.3.1 package.json via chromatic@6.18.0
Uses eval telejson 7.1.0 package.json via @storybook/react@7.0.18, @storybook/react-vite@7.0.18, storybook@7.0.18
Uses eval uglify-js 3.17.4 package.json via @storybook/react@7.0.18, @storybook/react-vite@7.0.18, storybook@7.0.18

Next steps

What is bin script confusion?

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is eval?

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore @storybook/cli@7.0.18
  • @SocketSecurity ignore storybook@7.0.18
  • @SocketSecurity ignore @aw-web-design/x-default-browser@1.4.88
  • @SocketSecurity ignore envinfo@7.8.1
  • @SocketSecurity ignore jake@10.8.7
  • @SocketSecurity ignore jscodeshift@0.14.0
  • @SocketSecurity ignore puppeteer-core@2.1.1
  • @SocketSecurity ignore shelljs@0.8.5
  • @SocketSecurity ignore vite@4.3.9
  • @SocketSecurity ignore @snyk/graphlib@2.1.9-patch.3
  • @SocketSecurity ignore @storybook/manager@7.0.18
  • @SocketSecurity ignore @storybook/preview@7.0.18
  • @SocketSecurity ignore @yarnpkg/lockfile@1.1.0
  • @SocketSecurity ignore ejs@3.1.9
  • @SocketSecurity ignore esbuild-register@3.4.2
  • @SocketSecurity ignore is-generator-function@1.0.10
  • @SocketSecurity ignore prettier@2.8.8
  • @SocketSecurity ignore promise@7.3.1
  • @SocketSecurity ignore telejson@7.1.0
  • @SocketSecurity ignore uglify-js@3.17.4
  • @SocketSecurity ignore react-refresh@0.14.0
  • @SocketSecurity ignore supports-hyperlinks@2.3.0
  • @SocketSecurity ignore for-each@0.3.3
  • @SocketSecurity ignore fb-watchman@2.0.2
  • @SocketSecurity ignore defaults@1.0.4
  • @SocketSecurity ignore anymatch@3.1.3
  • @SocketSecurity ignore querystringify@2.2.0
  • @SocketSecurity ignore assert@2.0.0
  • @SocketSecurity ignore fd-slicer@1.1.0
  • @SocketSecurity ignore cacheable-request@7.0.2
  • @SocketSecurity ignore fast-diff@1.3.0
  • @SocketSecurity ignore clone-response@1.0.3
  • @SocketSecurity ignore responselike@2.0.1
  • @SocketSecurity ignore write-file-atomic@2.4.3

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
storybook 🆕 7.0.18 None +318 273 MB shilman
vite 🆕 4.3.9 eval, network, filesystem, shell, environment +27 211 MB vitebot
eslint-plugin-storybook 🆕 0.6.12 None +24 73.8 MB yannbf
@storybook/react-vite 🆕 7.0.18 None +165 312 MB shilman
typescript ⬆️ 4.7.4...4.9.5 None +0/-0 66.8 MB typescript-bot
tsup ⬆️ 6.1.3...6.7.0 environment +41/-15 274 MB egoist
eslint-config-prettier ⬆️ 8.5.0...8.8.0 None +17/-14 6.58 MB lydell
@babel/register ⬆️ 7.18.6...7.21.0 None +29/-29 10.2 MB nicolo-ribaudo
@types/react ⬆️ 16.14.28...16.14.42 None +2/-2 1.39 MB types
@babel/preset-typescript ⬆️ 7.18.6...7.21.5 None +38/-35 10.6 MB nicolo-ribaudo
@babel/plugin-proposal-optional-chaining ⬆️ 7.18.6...7.21.0 None +31/-31 10.2 MB nicolo-ribaudo
@babel/plugin-transform-runtime ⬆️ 7.18.6...7.22.4 None +37/-37 11.5 MB nicolo-ribaudo
babel-loader ⬆️ 8.2.5...8.3.0 None +32/-71 10.3 MB nicolo-ribaudo
eslint ⬆️ 8.19.0...8.42.0 environment +16/-13 6.56 MB eslintbot
@babel/preset-react ⬆️ 7.18.6...7.22.3 None +32/-32 10.2 MB nicolo-ribaudo
@babel/plugin-proposal-logical-assignment-operators ⬆️ 7.18.6...7.20.7 None +30/-30 10.1 MB nicolo-ribaudo
@babel/core ⬆️ 7.18.6...7.22.1 None +28/-28 10.1 MB nicolo-ribaudo
chromatic ⬆️ 6.7.0...6.18.0 network +150/-1 36.2 MB ghengeveld
prettier ⬆️ 2.7.1...2.8.8 eval +0/-0 11.2 MB prettier-bot
@babel/preset-env ⬆️ 7.18.6...7.22.4 None +96/-86 14 MB nicolo-ribaudo
@storybook/react ⬆️ 6.5.9...7.0.18 None +107/-658 222 MB shilman
@babel/plugin-proposal-object-rest-spread ⬆️ 7.18.6...7.20.7 None +31/-31 10.3 MB nicolo-ribaudo

🚮 Removed packages: @storybook/builder-webpack5@6.5.9, @storybook/manager-webpack5@6.5.9, @typescript-eslint/eslint-plugin@5.30.4, @typescript-eslint/parser@5.30.4, webpack@5.73.0

Footnotes

  1. https://docs.socket.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant