Addon A11y: Make Vitest Axe optional #30442
Merged
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
force-pushed
the
valentin/make-vitest-axe-optional
branch
from
496c142 to
6e0c6f1
Compare
|
View your CI Pipeline Execution ↗ for commit 8569d2c.
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 6e0c6f1.
☁️ Nx Cloud last updated this comment at |
valentinpalkovic
added
bug
patch:yes
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 59 | 56 | 🎉 -3 🎉 |
| Self size | 228 KB | 332 KB | 🚨 +104 KB 🚨 |
| Dependency size | 13.47 MB | 12.71 MB | 🎉 -755 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
shilman
approved these changes
Feb 4, 2025
shilman
reviewed
Feb 4, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
60
to
61
| // @ts-expect-error - todo - fix type extension of expect from @storybook/test | ||
| expect(result).toHaveNoViolations(); |
There was a problem hiding this comment.
style: Consider adding a type assertion or updating @storybook/test types to properly handle the toHaveNoViolations matcher
valentinpalkovic
force-pushed
the
valentin/make-vitest-axe-optional
branch
from
ee9ebb5 to
8569d2c
Compare
valentinpalkovic
added
ci:daily
This was referenced Feb 4, 2025
shilman
pushed a commit
that referenced
this pull request
Feb 5, 2025
…ptional Addon A11y: Make Vitest Axe optional (cherry picked from commit b2d8a3c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #30423
What I did
vitestin@storybook/addon-a11yan optional peer-dependencyChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-30442-sha-6e0c6f13. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-30442-sha-6e0c6f13 sandboxor in an existing project withnpx storybook@0.0.0-pr-30442-sha-6e0c6f13 upgrade.More information
0.0.0-pr-30442-sha-6e0c6f13valentin/make-vitest-axe-optional6e0c6f131738576820)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=30442Greptile Summary
Makes the Vitest Axe dependency optional in the @storybook/addon-a11y package to prevent errors for users not using Vitest.
vitest-axefrom dependencies to devDependencies incode/addons/a11y/package.jsoncode/addons/a11y/src/preview.tsxto dynamically import Vitest Axe matchers only when neededvitestMatchersExtendedto ensure matchers are only extended once