Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oauth2 example for node js client #92

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add oauth2 example for node js client #92

wants to merge 4 commits into from

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Jan 15, 2022

@tuteng tuteng requested review from a team as code owners January 15, 2022 13:01
@tuteng tuteng requested review from jiazhai and sijie January 17, 2022 04:04
EronWright
EronWright suggested changes Jan 24, 2022
View reviewed changes
cloud/node/connect_by_oauth2.js Outdated Show resolved Hide resolved
@Huanli-Meng
Copy link
Contributor

@tuteng I noticed that the node.js client support Oauth2 authentication has been merged into the community. How about our SN process? Thanks.

Huanli-Meng
Huanli-Meng reviewed Feb 7, 2022
View reviewed changes
Copy link
Contributor

@Huanli-Meng Huanli-Meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave some comments, PTAL. Thanks.

cloud/node/connect_by_oauth2.js Outdated Show resolved Hide resolved
cloud/node/sample_consumer_by_oauth2.js Outdated Show resolved Hide resolved
cloud/node/sample_producer_by_oauth2.js Outdated Show resolved Hide resolved
cloud/node/README.md Outdated Show resolved Hide resolved
cloud/node/README.md Outdated Show resolved Hide resolved
@EronWright EronWright self-requested a review September 7, 2022 00:19
EronWright
EronWright reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@EronWright EronWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issuer_url should be obtained from the private key file, in preference to a command-line parameter (which would be needed if not using a private key file).

@tuteng
Copy link
Member Author

tuteng commented Sep 7, 2022 •
edited
Loading

The issuer_url should be obtained from the private key file, in preference to a command-line parameter (which would be needed if not using a private key file).

It seems that most language clients do not follow this specification -> https://pulsar.apache.org/docs/security-oauth2#c-client @EronWright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huanli-Meng Huanli-Meng Huanli-Meng left review comments

@EronWright EronWright EronWright requested changes

@jiazhai jiazhai jiazhai approved these changes

@sijie sijie Awaiting requested review from sijie

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuteng @Huanli-Meng @EronWright @jiazhai