Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dark Mode for Planet Page #4297

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

justin212407
Copy link
Contributor

@justin212407 justin212407 commented Jan 20, 2025

Description:

This PR introduces dark mode for the Planet page, building on the pr #4244 and providing an improved user experience. This feature applies consistent dark mode styles across all elements, including the navbar, buttons, cards, icons, and modals.

Changes Made:

This PR implements a complete dark mode for the Planet page, ensuring a cohesive and user-friendly experience across all elements. The navbar, background, cards, buttons, modals, dropdowns, and icons have been updated to align with the dark mode theme.

Screenshots/Video:

image

Checklist:

  • All dark mode styles adhere to the project's design guidelines.
  • Tested the page in both light mode and dark mode for consistency.
  • Adjusted styles for all components, including navbar, cards, modals, and buttons.
  • Ensured proper contrast ratios for text and interactive elements in dark mode.

Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>
@justin212407
Copy link
Contributor Author

@walterbender please review this i have made all the changes as we discussed in the meeting. I will also be creating another pr to add to the changes that have to be made to the main page.

@walterbender
Copy link
Member

Screenshot From 2025-01-20 12-31-30

The sort mechanism is not in darkmode

@justin212407
Copy link
Contributor Author

I'll fix it and add the commit

@walterbender
Copy link
Member

Also, please rebase from master so that the other dark mode code is in your branch.

@justin212407
Copy link
Contributor Author

okay sure i'll do that too

@justin212407
Copy link
Contributor Author

@walterbender are you talking about the sort mechanism present on the global page
image

Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>
@justin212407
Copy link
Contributor Author

I have changed the component you asked about also while looking for issues in other functionalities i found one in the delete notification i have fixed that too in this commit.
this is how the changes look now:

Untitled.video.-.Made.with.Clipchamp.1.mp4

@Commanderk3
Copy link
Contributor

Looks great mate 👍

@justin212407
Copy link
Contributor Author

@Commanderk3 Thanks mate. Was a great experience collaborsting with you

@Commanderk3
Copy link
Contributor

Thank you @justin21240
It was an absolute pleasure working with you as well.

@walterbender walterbender merged commit fe273d0 into sugarlabs:master Jan 21, 2025
4 checks passed
Ubayed-Bin-Sufian pushed a commit to Ubayed-Bin-Sufian/musicblocks that referenced this pull request Jan 24, 2025
* Added Dark Mode for Planet Page

Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>

* Updated sort mechanism and delete notification for dark mode

Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>

---------

Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants