Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Tone.js #4304

Merged
merged 1 commit into from
Jan 25, 2025
Merged

update Tone.js #4304

merged 1 commit into from
Jan 25, 2025

Conversation

haroon10725
Copy link
Contributor

@haroon10725 haroon10725 commented Jan 24, 2025

@walterbender Can you please review this.
Updated Tone.js v14.7.40 to Tone.js v15.0.4

@omsuneri
Copy link
Contributor

@haroon10725 can you just tell me like what the error with the lib/tone.js

@pikurasa
Copy link
Collaborator

pikurasa commented Jan 24, 2025

This will need some testing.

I did a few tests, such as:

  • Basic smoke test
  • Basic playback test both with synth and with samples
  • Test of Timbre Widget

So far, it passes all of these tests, but I think we should spend some more time testing this before we merge it. We should also document a list of things to test every time we update tone.js.

@haroon10725
Copy link
Contributor Author

haroon10725 commented Jan 24, 2025

@pikurasa Sure.
I can test all the widgets that uses Tone.js

@haroon10725
Copy link
Contributor Author

@haroon10725 can you just tell me like what the error with the lib/tone.js

Updated the library

@pikurasa
Copy link
Collaborator

@pikurasa Sure. I can test all the widgets that uses Tone.js

Pretty much everything in MB that makes sounds uses tone.js.

I think what we should look for are any errors that may come up with different ways we use tone.js, as well as whether or not there is a difference in overall performance.

@walterbender
Copy link
Member

Sampler should be tested too.

@haroon10725
Copy link
Contributor Author

image

@walterbender @pikurasa These warnings have also been removed by updating Tone.js. There were some depreciated methods.
I also tested sampler widget, works fine.

@walterbender walterbender merged commit 24169b5 into sugarlabs:master Jan 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants