Enhanced Footer. Fixes issue #635. #639
Conversation
|
Great job on your work so far! However, please try to avoid making unnecessary changes, such as adding or removing spaces, as it makes it harder to review the intended changes. I suggest checking the working tree before committing the code to the branch. This will give you an idea of what changes are going to be included in the commit. Also, please write any new CSS in the |
_includes/footer.html
Outdated
| (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){ | ||
| (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o), | ||
| m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m) | ||
| })(window,document,'script','https://www.google-analytics.com/analytics.js','ga'); | ||
| ga('create', 'UA-102776855-1', 'auto'); | ||
| ga('send', 'pageview'); | ||
| </script> | ||
| </script> |
There was a problem hiding this comment.
Please don't remove the newline at end of this file.
There was a problem hiding this comment.
Ahh..really really sorry. It's just a force of habit. I will make sure to change it as soon as I get to my PC.
|
@imshrishk Issue #647 is now solved. Is there another reason this should still be merged as-is? |
|
I tested it, and I'm not persuaded. For more context on our priorities, I recommend joining us on https://matrix.to/#/#sugarlabs-web:matrix.org and attending the meetings. |
|
No problem! I joined the group and hope to collaborate better with the team. |
Made the Footer responsive as per the requirements.
Made a few indentation changes to make the code more readable.