This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parquet_derive for the new RecordWriter trait #197
parquet_derive for the new RecordWriter trait #197
Changes from 12 commits
38ec590
5b0c5f4
44461f2
2bdbbfd
313bd7e
5c7e8fd
451c51c
e4cee5b
a0c9792
99eb1d1
3b0ae7a
1f6d829
38326b6
22e6653
fcf86b7
71ed787
29b397c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Byte arrays and unsigned variants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call on the unsigned variants. To be clear, to satisfy that requirement I need to add
u32
/u64
, right? Parquet does not handle 8 or 16 bit values, right?And when it comes to "byte arrays", are you talking fixed-sized arrays like
let arr : [u8; 16] = [0; 16];
? Or do you meanlet vec : Vec<u8> = vec![0; 16];
? I haven't used either of those in parquet-rs so I need a little guidance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By "byte arrays" I meant parquet type ByteArray, not just strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sadikovi how do I write unsigned variants? I don't see a column writer for that.