Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

Update rust format to fix build #199

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Conversation

sadikovi
Copy link
Collaborator

@sadikovi sadikovi commented Dec 3, 2018

This PR makes a few small changes to fix format and make build pass. Not sure why it did not pick up the changes on my machine.

@sadikovi sadikovi force-pushed the fix-build branch 2 times, most recently from 0f4a126 to 8eea52b Compare December 3, 2018 22:19
Copy link
Owner

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although I think we haven't solved the root cause yet - something may be wrong in the CI which uses the wrong fmt checker.

@sadikovi
Copy link
Collaborator Author

sadikovi commented Dec 3, 2018

Yes, I also can't reproduce it locally.

@sunchao sunchao merged commit 30a62a0 into sunchao:master Dec 4, 2018
@xrl
Copy link
Contributor

xrl commented Dec 4, 2018

I have this issue as well, it's the source of failure in #197. I will merge this work in and retest on travis.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants