Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify configurable exception classes in setter method #132

Merged

Conversation

viralpraxis
Copy link
Contributor

I doubt anyone will intentionally set argument_error_class/failure_class to some non-exception objects, but it's possible due to dummy mistake or misunderstanding. The problem here is that it wont be noticed until we try to raise something unraisable in actor failure scenario

So I think we can be a little be more defensive here

@sunny I'll add a changelog entry if you approve the idea

Copy link
Owner

@sunny sunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! It makes much sense, I’m all for being more defensive 👏🏻

@viralpraxis
Copy link
Contributor Author

Awesome! It makes much sense, I’m all for being more defensive 👏🏻

Updated changelog 👍🏻

@sunny sunny merged commit b70535a into sunny:main Feb 29, 2024
7 checks passed
@sunny
Copy link
Owner

sunny commented Feb 29, 2024

👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants