Add pattern matching support for Result #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #133
I'm not sure if we should use
success?: true, failure?: false
orsuccess: true, failure: false
. Since we are handling hashes, I don't like the?
on keys.ps. There is error on linter because it is using Ruby 2.4 parser and pattern matching is supported on >= 2.7. It can be fixed with:
But it will recommend another improvements on other files.