Fix crash when GitLab commit author is null (#318)

sveltia · Feb 2, 2025 · c59de02 · c59de02
1 parent 3179e74
commit c59de02
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/src/lib/services/backends/gitlab.js b/src/lib/services/backends/gitlab.js
@@ -493,7 +493,7 @@ const fetchFileContents = async (fetchingFiles) => {
 
   /**
    * @type {{
-   * author: { id?: string, username?: string },
+   * author: { id?: string, username?: string } | null,
    * authorName: string, authorEmail: string, committedDate: string
    * }[]}
    */
@@ -508,7 +508,7 @@ const fetchFileContents = async (fetchingFiles) => {
       const result = //
         /**
          * @type {{ project: { repository: { [tree_index: string]: { lastCommit: {
-         * author: { id?: string, username?: string },
+         * author: { id?: string, username?: string } | null,
          * authorName: string, authorEmail: string, committedDate: string
          * } } } } } }}
          */ (
@@ -563,13 +563,8 @@ const fetchFileContents = async (fetchingFiles) => {
       };
 
       if (commit) {
-        const {
-          author: { id, username },
-          authorName,
-          authorEmail,
-          committedDate,
-        } = commit;
-
+        const { author, authorName, authorEmail, committedDate } = commit;
+        const { id, username } = author ?? {};
         const idMatcher = id?.match(/\d+/);
 
         data.meta = {