Skip to content

Commit

Permalink
EmbeddedPkg: CodeQL Fixes.
Browse files Browse the repository at this point in the history
Makes changes to comply with alerts raised by CodeQL.

Most of the issues here fall into the following two categories:

1. Potential use of uninitialized pointer.
2. Inconsistent integer width in comparison.

Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com>
Co-authored-by: Ken Lautner <kenlautner3@gmail.com>
Co-authored-by: Bret Barkelew <bret@corthon.com>
Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
  • Loading branch information
4 people authored and mergify[bot] committed Jan 15, 2025
1 parent d6f828b commit aae044a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
3 changes: 3 additions & 0 deletions EmbeddedPkg/Library/PrePiHobLib/Hob.c
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,9 @@ BuildGuidDataHob (
ASSERT (Data != NULL || DataLength == 0);

HobData = BuildGuidHob (Guid, DataLength);
if (HobData == NULL) {
return NULL;
}

return CopyMem (HobData, Data, DataLength);
}
Expand Down
2 changes: 1 addition & 1 deletion EmbeddedPkg/Library/PrePiLib/FwVol.c
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ FfsProcessSection (
{
EFI_STATUS Status;
UINT32 SectionLength;
UINT32 ParsedLength;
UINTN ParsedLength;
EFI_COMPRESSION_SECTION *CompressionSection;
EFI_COMPRESSION_SECTION2 *CompressionSection2;
UINT32 DstBufferSize;
Expand Down
3 changes: 3 additions & 0 deletions EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOut.c
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,9 @@ OutputString (

Size = StrLen (String) + 1;
OutputString = AllocatePool (Size);
if (OutputString == NULL) {
return EFI_OUT_OF_RESOURCES;
}

// If there is any non-ascii characters in String buffer then replace it with '?'
// Eventually, UnicodeStrToAsciiStr API should be fixed.
Expand Down

0 comments on commit aae044a

Please sign in to comment.