Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OAuth examples #1228

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Update OAuth examples #1228

merged 5 commits into from
Mar 26, 2024

Conversation

jkoskela
Copy link
Collaborator

Update OAuth examples

  • Add example for Azure with IAM IDC which requires a custom scope
  • Add more comments
  • Switch username mapping to use email
  • Add an example with a config label
  • Remove invalid response parameter from Azure (access-token-issue-time)

pvanderknyff
pvanderknyff approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@pvanderknyff pvanderknyff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkoskela jkoskela merged commit 546979b into master Mar 26, 2024
18 of 19 checks passed
@jkoskela jkoskela deleted the jkoskela/oauth-updates-3.24 branch January 21, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsun-tableau zsun-tableau zsun-tableau approved these changes

@pvanderknyff pvanderknyff pvanderknyff approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkoskela @pvanderknyff @zsun-tableau