fix for extension hanging on analysis of non-'.spthy' files #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue with the Tamarin extension trying to analyze non-Tamarin files, and depending on the file type hanging indefinitely (and triggering VS-Code resource consumption warnings), or showing wrong error messages.
I don't really do VS extension development, so I was unsure how to properly test the (albeit miniscule) changes for general impact/compatibility outside of running "npm test".
For the original issue, I did successfully test locally.
Feel free to move the language check upwards in the call trace - I did not want to understand the entire extension (and how VSCode extensions might get invoked) and just added a "fail-save" in the actual analysis function.