Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Handle non-direct binding cases in ResolveExports #3488

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Editorial: Handle non-direct binding cases in ResolveExports #3488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54d19ac
Add an assertion for ResolveExport
kimjg1119 Nov 20, 2024
5a119c8
Accept suggestion
kimjg1119 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28211,6 +28211,7 @@ <h1>
1. For each ExportEntry Record _e_ of _module_.[[IndirectExportEntries]], do
1. If _e_.[[ExportName]] is _exportName_, then
1. Assert: _e_.[[ModuleRequest]] is not *null*.
1. Assert: _e_.[[ImportName]] is neither ~all-but-default~ nor *null*.
kimjg1119 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of ruling out two of the four possible states here, and then switching between the remaining two later, I would add another assert in the "else" case below (after the existing "imports a specific binding" assert):

                  1. Assert: _e_.[[ImportName]] is a String.

That seems clearer.

1. Let _importedModule_ be GetImportedModule(_module_, _e_.[[ModuleRequest]]).
1. If _e_.[[ImportName]] is ~all~, then
1. Assert: _module_ does not provide the direct binding for this export.
Expand Down
Loading