Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e, scripts] Start K8s e2e from helmfile #3929

Merged
merged 37 commits into from
Jan 31, 2025
Merged

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Jan 29, 2025

This PR makes the following changes:

  • creates a helm directory in e2e with the following:
    • helmfile.yaml
    • values.yaml
    • modified elastic/elasticsearch-6.8.9 chart
    • modified elastic/elasticsearch-7.9.3 chart
    • modified confluentinc/cp-helm-charts-0.6.1 chart (kafka and zookeeper)
    • go templates for teraslice and services
  • update the teraslice helm chart to include the autoload_directory
  • update ts-scripts test to start k8s e2e tests via helmfile using the -use-helmfile` flag
  • update e2e to use helmfile commands instead of the k8s api when started via helm
  • update default service versions for tests
    • kafka version from 3.5 to 3.7, which is cp-kafka:v7.7.2
    • opensearch1 from 1.3.10 to 1.3.11
    • opensearch2 from 2.8.0 to 2.15.0
  • k8s e2e tests now run on opensearch2, not elasticsearch7
  • update mappings between kafka and cp-kafka versions
  • bump e2e version from 0.7.1 to 0.8.0
  • bump scripts version from 1.9.3 to 1.10.0

ref: #3931, #3906

@busma13 busma13 force-pushed the k8s-e2e-from-helm-chart branch from 7b800fa to 4f689d1 Compare January 30, 2025 21:18
@busma13 busma13 marked this pull request as ready for review January 30, 2025 22:04
@busma13 busma13 requested review from sotojn and godber January 31, 2025 17:23
@busma13 busma13 changed the title K8s e2e from helm chart [e2e, scripts] Start K8s e2e from helmfile Jan 31, 2025
@sotojn
Copy link
Contributor

sotojn commented Jan 31, 2025

I see that the k8sV2 tests run opensearch2 but the regular k8se2e still runs elasticsearch7. Is this intentional or are we supposed to run both with opensearch2?

.github/workflows/test.yml Outdated Show resolved Hide resolved
e2e/helm/elasticsearch/README.md Outdated Show resolved Hide resolved
e2e/helm/templates/kafka.yaml.gotmpl Outdated Show resolved Hide resolved
e2e/helm/templates/kafka.yaml.gotmpl Outdated Show resolved Hide resolved
e2e/package.json Show resolved Hide resolved
@godber
Copy link
Member

godber commented Jan 31, 2025

Discussed over zoom:

  • For now lets keep the e2e K8s v1 tests, leave them as is, they are not worth updating, I think we are close to getting rid of them.

@busma13 busma13 force-pushed the k8s-e2e-from-helm-chart branch from 901dcee to 7a3a681 Compare January 31, 2025 21:22
Copy link
Contributor

@sotojn sotojn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@busma13 busma13 merged commit 10882d9 into master Jan 31, 2025
46 checks passed
@busma13 busma13 deleted the k8s-e2e-from-helm-chart branch January 31, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants