fix: use ecto migrator with_repo to avoid swallowing errors

lib/ecto.ex

@@ -275,8 +275,6 @@
             )
           )
 
-        {:ok, pid} = repo.start_link()
-
         absolute_migrations_path =
           if Path.absname(migrations_path) != migrations_path,
             do: Application.app_dir(app, migrations_path),
@@ -291,17 +289,27 @@
               :ok
           end
 
-        Ecto.Migrator.run(repo, absolute_migrations_path, :up, all: true)
-
-        GenServer.stop(pid)
-
-        {:ok, container}
+        with {:ok, _, _} <- run_migrations(repo, absolute_migrations_path) do
+          {:ok, container}
+        end
 
       {:error, reason} ->
         {:error, reason}
     end
   end
 
+  defp run_migrations(repo, migrations_path) do
+    try do
+      Ecto.Migrator.with_repo(
+        repo,
+        &Ecto.Migrator.run(&1, migrations_path, :up, all: true)
+      )
+    rescue
+      e ->
+        {:error, e}
+    end
+  end
+
   defp camelize(string) do
     string
     |> String.split("_")

test/ecto_errors_test.exs

@@ -4,14 +4,18 @@ defmodule Testcontainers.EctoErrorsTest do
   import Testcontainers.Ecto
 
   test "repo cannot be nil" do
-    assert_raise UndefinedFunctionError,
-                 "function Testcontainers.Repo.start_link/0 is undefined (module Testcontainers.Repo is not available)",
-                 fn ->
-                   mysql_container(
-                     app: :testcontainers,
-                     repo: nil
-                   )
-                 end
+    assert {:error,
+            %UndefinedFunctionError{
+              module: Testcontainers.Repo,
+              function: :config,
+              arity: 0,
+              reason: nil,
+              message: nil
+            }} =
+             mysql_container(
+               app: :testcontainers,
+               repo: nil
+             )
   end
 
   test "repo must be atom" do

test/ecto_mysql_test.exs

@@ -20,4 +20,13 @@ defmodule Testcontainers.EctoMysqlTest do
     assert Testcontainers.MysqlRepo.all(Testcontainers.TestUser) == []
     Testcontainers.stop_container(container.container_id)
   end
+
+  test "fails properly when migrations doesnt pass successfully" do
+    assert {:error, %MyXQL.Error{message: "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'stringa NOT NULL, `hashed_password` varchar(255) NOT NULL, `confirmed_at` dateti' at line 1"}} =
+             mysql_container(
+               app: :testcontainers,
+               migrations_path: "#{__DIR__}/support/bad_migrations",
+               repo: Testcontainers.MysqlRepo
+             )
+  end
 end

test/ecto_postgres_test.exs

@@ -20,4 +20,13 @@ defmodule Testcontainers.EctoPostgresTest do
     assert Testcontainers.PostgresRepo.all(Testcontainers.TestUser) == []
     Testcontainers.stop_container(container.container_id)
   end
+
+  test "fails properly when migrations doesnt pass successfully" do
+    assert {:error, %Postgrex.Error{postgres: %{message: "type \"stringa\" does not exist"}}} =
+             postgres_container(
+               app: :testcontainers,
+               migrations_path: "#{__DIR__}/support/bad_migrations",
+               repo: Testcontainers.PostgresRepo
+             )
+  end
 end

test/support/bad_migrations/20231022122557_add_posts_table.exs

@@ -0,0 +1,12 @@
+defmodule Testcontainers.Repo.Migrations.AddPostsTable do
+  use Ecto.Migration
+
+  def change do
+    create table(:users) do
+      add(:email, :stringa, null: false)
+      add(:hashed_password, :string, null: false)
+      add(:confirmed_at, :naive_datetime)
+      timestamps()
+    end
+  end
+end