Re-enable setAutoArchiveDuration + isWeekend check
#333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Notes Let's re-enable the `setAutoArchiveDuration` to 24 hours / `OneDay` after the initial warning message is sent.
This checks whether it's `isWeekend` before running the thread status, if it is we return.
zuuring
changed the title
setAutoArchiveDuration on thread decisionssetAutoArchiveDuration + isWeekend check
Shadowfiend
approved these changes
Jan 28, 2025
| ThreadAutoArchiveDuration.OneDay | ||
|
|
||
| // Let's grab if it's the weekend, 0 = sunday, 6 = saturday | ||
| const isWeekend = (): boolean => [0, 6].includes(new Date().getDay()) |
There was a problem hiding this comment.
Also thinking about holidays here, rough stuff. I wonder if we avoid Mondays as well for that reason 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Let's re-enable the
setAutoArchiveDurationto 24 hours /OneDayafter the initial warning message is sent. This one also adds aisWeekendcheck so that we don't send thread decision reminders during the weekend days.