Add hostname to events (#16419)

...so that its easier to filter out localhost and herokuapp domains
thin1803 · Nov 16, 2020 · 714ca02 · 714ca02
1 parent db4fad8
commit 714ca02
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/javascripts/events.js b/javascripts/events.js
@@ -63,6 +63,7 @@ export function sendEvent ({
 
       // Content information
       path: location.pathname,
+      hostname: location.hostname,
       referrer: document.referrer,
       search: location.search,
       href: location.href,

diff --git a/lib/schema-event.js b/lib/schema-event.js
@@ -39,6 +39,11 @@ const context = {
       description: 'The browser value of `location.pathname`.',
       format: 'uri-reference'
     },
+    hostname: {
+      type: 'string',
+      description: 'The browser value of `location.hostname.`',
+      format: 'uri-reference'
+    },
     referrer: {
       type: 'string',
       description: 'The browser value of `document.referrer`.',

diff --git a/tests/rendering/events.js b/tests/rendering/events.js
@@ -48,6 +48,7 @@ describe('POST /events', () => {
 
       // Content information
       path: '/github/docs/issues',
+      hostname: 'github.com',
       referrer: 'https://github.com/github/docs',
       search: '?q=is%3Aissue+is%3Aopen+example+',
       href: 'https://github.com/github/docs/issues?q=is%3Aissue+is%3Aopen+example+',
@@ -138,6 +139,16 @@ describe('POST /events', () => {
       }, 400)
     )
 
+    it('should hostname be uri-reference', () =>
+      checkEvent({
+        ...pageExample,
+        context: {
+          ...pageExample.context,
+          hostname: ' '
+        }
+      }, 400)
+    )
+
     it('should referrer be uri-reference', () =>
       checkEvent({
         ...pageExample,