chore(hesai): replace broadcast host_ip
#256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the the `host_ip` default config parameter fith one that is not the broadcast address - broadcast is disallowed by Nebula since #231 Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
mojomex
added a commit
that referenced
this pull request
Feb 3, 2025
commit d14c183 Author: Max SCHMELLER <max.schmeller@tier4.jp> Date: Mon Feb 3 19:11:10 2025 +0900 chore(hesai): replace broadcast `host_ip` Replace the the `host_ip` default config parameter fith one that is not the broadcast address - broadcast is disallowed by Nebula since #231 Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
==========================================
- Coverage 27.24% 0.00% -27.25%
==========================================
Files 104 91 -13
Lines 9445 8093 -1352
Branches 2324 973 -1351
==========================================
- Hits 2573 0 -2573
- Misses 6436 8093 +1657
+ Partials 436 0 -436
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
host_ipDescription
Replace the the
host_ipdefault config parameter with one that is not the broadcast address - broadcast is disallowed by Nebula since #231.Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks