Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference: unify notation for targets #227

Merged
merged 2 commits into from
Jan 20, 2022
Merged

reference: unify notation for targets #227

merged 2 commits into from
Jan 20, 2022

Conversation

sago35
Copy link
Member

@sago35 sago35 commented Dec 29, 2021

see #226

@sago35
Copy link
Member Author

sago35 commented Dec 29, 2021

This is the same notation and order as tinygo-org/tinygo/README.md, which makes it easier to check for missing documentation.
This allows, for example, STM32 microcontrollers to be lined up close together.

image

aykevl
aykevl reviewed Dec 30, 2021
View reviewed changes
Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but see the comment below.

content/docs/reference/microcontrollers/hifive1b.md Outdated Show resolved Hide resolved
@sago35 @aykevl
Update content/docs/reference/microcontrollers/hifive1b.md
a8527c8 
Co-authored-by: Ayke <aykevanlaethem@gmail.com>
@sago35
Copy link
Member Author

sago35 commented Dec 31, 2021

Updated.

After this, create a PR that also modifies tinygo-org/tinygo/README.md to SiFive HiFive1 Rev B .

@sago35 sago35 mentioned this pull request Dec 31, 2021
Merged
@sago35
Copy link
Member Author

sago35 commented Jan 19, 2022

@aykevl
Please check it.

@deadprogram
Copy link
Member

Good cleanup here @sago35 thanks! Now merging.

@deadprogram deadprogram merged commit ca2c614 into dev Jan 20, 2022
@deadprogram deadprogram deleted the unify-notation branch January 20, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aykevl aykevl aykevl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sago35 @deadprogram @aykevl