Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read stdout before stderr #41

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio requested a review from 43081j December 4, 2024 09:26
AriPerkkio added a commit to AriPerkkio/vitest that referenced this pull request Dec 4, 2024
@43081j
Copy link
Member

43081j commented Dec 4, 2024

Do you know why this is?

Is the behaviour documented somewhere? Everything you explained makes sense but it seems like we just know through trial and error

@AriPerkkio
Copy link
Member Author

No idea why this happens. I haven't run into this ever before even though I've used node:child_process in multiple projects in various ways.

I checked the Node docs but couldn't find anything related to this.

AriPerkkio added a commit to AriPerkkio/vitest that referenced this pull request Dec 9, 2024
AriPerkkio added a commit to AriPerkkio/vitest that referenced this pull request Dec 9, 2024
AriPerkkio added a commit to AriPerkkio/vitest that referenced this pull request Dec 11, 2024
AriPerkkio added a commit to AriPerkkio/vitest that referenced this pull request Dec 13, 2024
AriPerkkio added a commit to AriPerkkio/vitest that referenced this pull request Dec 13, 2024
AriPerkkio added a commit to AriPerkkio/vitest that referenced this pull request Dec 19, 2024
@43081j
Copy link
Member

43081j commented Dec 28, 2024

We don't fully understand why this is the case still, but I'll merge since it shouldn't have any negative effect.

We should still ask around to find out why this fixes the problem

@43081j 43081j merged commit 2adbaf7 into tinylibs:main Dec 28, 2024
7 checks passed
@AriPerkkio AriPerkkio deleted the fix/missing-stdout branch December 28, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing stdout due to closed stream
2 participants