Skip to content

Commit

Permalink
DOC-2318: revert removal, add updates and fix other incorrect option …
Browse files Browse the repository at this point in the history
…references.
  • Loading branch information
kemister85 committed Mar 6, 2024
1 parent a2920f9 commit 4cd8a99
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ tinymce.ScriptLoader.loadScripts(
setup: (editor) => {
editor.on('SkinLoaded', () => {
editor.execCommand('ToggleSidebar', false, 'showcomments', {
skip_focus: true,
skipFocus: true,
});
});
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ tinymce.init({
/* The following setup callback opens the comments sidebar when the editor loads */
setup: (editor) => {
editor.on('SkinLoaded', () => {
editor.execCommand('ToggleSidebar', false, 'showcomments', { skip_focus: true });
editor.execCommand('ToggleSidebar', false, 'showcomments', { skipFocus: true });
});
}
});
6 changes: 3 additions & 3 deletions modules/ROOT/pages/6.1-release-notes.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -224,11 +224,11 @@ This caused {productname} to present as if an undo option was available when the
This update fixes this bug. When the Comments plugin loads, the comment model data is no longer placed into an undo level and no Undo actions will present as available until there are actual changes available to undo.


==== Opening the comments sidebar via an editor command did not respect the `skip_focus` argument
==== Opening the comments sidebar via an editor command did not respect the `skipFocus` argument

If the Comments sidebar was opened with an editor command and `skip_focus` was set to true — `editor.execCommand("ToggleSidebar", false, "showcomments", { skip_focus: true });` — the sidebar still stole focus.
If the Comments sidebar was opened with an editor command and `skipFocus` was set to true — `editor.execCommand("ToggleSidebar", false, "showcomments", { skipFocus: true });` — the sidebar still stole focus.

This update corrects this: `skip_focus: true` is honored, as expected, and the sidebar does not steal focus.
This update corrects this: `skipFocus: true` is honored, as expected, and the sidebar does not steal focus.


==== Comments did not block the sidebar UI while saving the data in callback mode
Expand Down
9 changes: 9 additions & 0 deletions modules/ROOT/pages/6.4.1-release-notes.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,15 @@ tinymce.init({
[NOTE]
More details about this component and the possible values that can be used within the new `fontsizeinput` input field can be found in `xref:available-toolbar-buttons.adoc#the-core-toolbar-buttons[fontsizeinput]`.

=== Added `skipFocus` check to the ToggleToolbarDrawer command
//#TINY-9337

In previous versions of {productname}, the *ToggleToolbarDrawer* command contained an incorrect focus call. As a consequence, this meant that when the *ToggleToolbarDrawer* command option `skipFocus: true` was set the toolbar drawer would take focus when it was not meant to.

In {productname} 6.4.1, an improvement was made to the focusing code which now checks for `skipFocus`.

As a result of the fix, when using the *ToggleToolbarDrawer* command, the toolbar is now not focused when `skipFocus: true` is set.

=== New font_size_input_default_unit option allows to use of numbers without a unit in `fontsizeinput` and have them parsed with the default unit, if it is not defined the default is `pt`
//#TINY-9585

Expand Down
2 changes: 1 addition & 1 deletion modules/ROOT/pages/6.5.1-release-notes.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ In previous versions of {productname}, the default behavior of `editor.execComma

As a consequence, when pressing the fullscreen button the editor used `editor.execCommand('mceFullScreen')`, which caused the insertion point to be positioned incorrectly on iOS.

To resolve this issue, {productname} 6.5.1, includes `skip_focus: true` as a parameter for the `mceFullScreen` command. Consequently, the Full Screen button no longer attempts to focus back on the editor.
To resolve this issue, {productname} 6.5.1, includes `skipFocus: true` as a parameter for the `mceFullScreen` command. Consequently, the Full Screen button no longer attempts to focus back on the editor.

==== Advanced Code Editor did not preserve changes to _font size_ or _dark/light mode_ state.
//#TINY-9749
Expand Down
2 changes: 1 addition & 1 deletion modules/ROOT/pages/changelog.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ NOTE: This is the {productname} Community version changelog. For information abo
* New `setText` and `setIcon` methods added to menu button and toolbar button APIs.
* New `highlight_on_focus` option which enables highlighting the content area on focus.
* New `fontsizeinput` toolbar item which allows the user to set the size via input and also increase and decrease it with `+` and `-` buttons.
* Added `skip_focus` check to the ToggleToolbarDrawer command.
* Added `skipFocus` check to the ToggleToolbarDrawer command.
* New `font_size_input_default_unit` option allows to use of numbers without a unit in `fontsizeinput` and have them parsed with the default unit, if it is not defined the default is `pt`.
* New `group` and `togglebutton` in view.
* New `togglebutton` in dialog footer buttons.
Expand Down

0 comments on commit 4cd8a99

Please sign in to comment.