Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-1944: Remove deprecated open source Template Plugin for TinyMCE 7.0. #3067

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

kemister85
Copy link
Contributor

@kemister85 kemister85 commented Feb 12, 2024

Ticket: DOC-1944

Site: DOC-1944 site

Changes: 18 files changed Remove deprecated open source Template Plugin for TinyMCE 7.0.

  • delete modules/ROOT/examples/live-demos/template/index.html
  • delete modules/ROOT/examples/live-demos/template/index.js
  • delete modules/ROOT/pages/template.adoc
  • delete modules/ROOT/partials/commands/template-cmds.adoc
  • delete modules/ROOT/partials/configuration/template_cdate_classes.adoc
  • delete modules/ROOT/partials/configuration/template_cdate_format.adoc
  • delete modules/ROOT/partials/configuration/template_mdate_classes.adoc
  • delete modules/ROOT/partials/configuration/template_mdate_format.adoc
  • delete modules/ROOT/partials/configuration/template_preview_replace_values.adoc
  • delete modules/ROOT/partials/configuration/template_replace_values.adoc
  • delete modules/ROOT/partials/configuration/template_selected_content_classes.adoc
  • delete modules/ROOT/partials/configuration/templates.adoc

Pre-checks:

  • Branch prefixed with feature/6/ or hotfix/6/
  • modules/ROOT/nav.adoc has been updated (if applicable)
  • Files has been included where required (if applicable)
  • Files removed have been deleted, not just excluded from the build (if applicable)
  • Verify all affected demos are still functional

Review:

  • Documentation Team Lead has reviewed

@kemister85 kemister85 requested a review from a team as a code owner February 12, 2024 11:16
@kemister85 kemister85 requested review from TheSpyder, ltrouton, tiny-ben-tran and danoaky-tiny and removed request for a team February 12, 2024 11:16
@FarzadHayat FarzadHayat added the upcoming release Documentation for features currently under development/QA label Feb 13, 2024
@FarzadHayat FarzadHayat added this to the TinyMCE 7.0 milestone Feb 13, 2024
@FarzadHayat
Copy link
Contributor

Verified the following live-demos still run without console errors and template plugin has been removed from Help dialog.

Have not verified code samples yet.

Copy link
Contributor

@ShiridiGandham ShiridiGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kemister85 kemister85 merged commit 9b91ffe into staging/docs-7 Feb 25, 2024
5 checks passed
@kemister85 kemister85 deleted the feature/7.0/DOC-1944 branch February 25, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upcoming release Documentation for features currently under development/QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants