Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-2432: Update mention text of radio buttons to read checkbox instead. #3316

Merged
merged 2 commits into from
Jun 5, 2024
Merged

DOC-2432: Update mention text of radio buttons to read checkbox instead. #3316

merged 2 commits into from
Jun 5, 2024

Conversation

kemister85
Copy link
Contributor

@kemister85 kemister85 commented Jun 3, 2024 •
edited
Loading

Ticket: DOC-2432

Changes:

  • replace mentions of radio buttons to render checkbox in all documentation pages.

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/

Review:

  • Documentation Team Lead has reviewed

@kemister85 kemister85 requested review from a team, jscasca, ltrouton and MitchC1999 and removed request for a team June 3, 2024 03:26
@kemister85 kemister85 requested a review from a team as a code owner June 3, 2024 03:26
MitchC1999
MitchC1999 approved these changes Jun 4, 2024
View reviewed changes
modules/ROOT/pages/pageembed.adoc Outdated Show resolved Hide resolved
@kemister85 @MitchC1999
Update modules/ROOT/pages/pageembed.adoc
b6a1402 
Co-authored-by: Mitchell Crompton <mitchell.crompton@tiny.cloud>
@kemister85 kemister85 merged commit 9673140 into tinymce/7 Jun 5, 2024
5 checks passed
@kemister85 kemister85 deleted the hotfix/7/DOC-2432 branch June 5, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danoaky-tiny danoaky-tiny danoaky-tiny approved these changes

@MitchC1999 MitchC1999 MitchC1999 approved these changes

@jscasca jscasca Awaiting requested review from jscasca jscasca was automatically assigned from tinymce/editor-platform-team

@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton was automatically assigned from tinymce/editor-platform-team

@sabisabisabisab sabisabisabisab Awaiting requested review from sabisabisabisab sabisabisabisab is a code owner automatically assigned from tinymce/documentation-team

@katepotemina katepotemina Awaiting requested review from katepotemina katepotemina is a code owner automatically assigned from tinymce/documentation-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kemister85 @MitchC1999 @danoaky-tiny