Avoid expensive collection calls #24770
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/avoid-contains-all
branch
from
413ec91 to
a17efc1
Compare
losipiuk
reviewed
Jan 22, 2025
|
@losipiuk it depends on how wide the table is, right? |
losipiuk
reviewed
Jan 22, 2025
|
|
||
| public static boolean containsNone(Collection<Symbol> values, Collection<Symbol> testValues) | ||
| { | ||
| return values.stream().noneMatch(ImmutableSet.copyOf(testValues)::contains); |
There was a problem hiding this comment.
why iterate this one and not the other
There was a problem hiding this comment.
This method was just moved to a single utility class. It didn't change over the original one :)
Yep - but if you look at how this is used we iterate over hashSymbol, or groupingSymbols; and in non-pathological case there should not be many of those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: