[Fix] use unrestricted http client only for non-safe requests #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Restricted Client for non-safe APIs.
ahrav
approved these changes
Jan 21, 2025
| @@ -126,7 +126,7 @@ func (r AnalyzerRoundTripper) RoundTrip(req *http.Request) (*http.Response, erro | |||
|
|
|||
| // methodIsSafe is a helper method to check whether the HTTP method is safe according to MDN Web Docs. | |||
| // https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods#safe_idempotent_and_cacheable_request_methods | |||
| func methodIsSafe(method string) bool { | |||
| func MethodIsSafe(method string) bool { | |||
There was a problem hiding this comment.
nit: If we rename this to IsMethodSafe, it might read more clearly at the call site as a bool check. Otherwise, it could give the impression that we’re trying to convert the method into a safe one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
PR #3841 removes all the safety majors on OpsGenie Analyzer. This PR use unrestricted http client only for non-safe operations. Other than that restricted one will be used as usual.
Checklist:
make test-community)?make lintthis requires golangci-lint)?