handling memory normalization when only bytes are passed #273
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprised only of digits (which is number of bytes). to handle this, the initial value of valuePart and unitPart is set to this case, if there are letters in the string, the matching values will be set accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the if condition doesn't handle the case when the memory string is comprised only of digits (which is number of bytes). to handle this, the initial value of valuePart and unitPart is set to this case, if there are letters in the string, the matching values will be set accordingly.
initially got error:
Error: kubernetes: failed to populate column 'containers_resources_requests_std': invalid memory value: 1288490189 (SQLSTATE HV000)
And now, followed the guidelines to test it locally, and it worked for me :)