#DIGREPO-935: Process Merritt Atom Feed to ingest ETDs #184
Conversation
Begin consuming the feed through an import task. Capture paginated feed log in Merritt::Feed. Capture feed entries(ETDs) in Merritt::Etd.
Do not see a need for capturing merritt feed log in db.
Add check for etd collection. Add module to ingest Etd.
Update Proquest::Xml to extract ETD metadata sttributes
Use iso639 gem to convert language from iso639_1 to iso639_2.
… range of 9 to 14, but got: 8'
…uotes for way too long
…c failure that was a side effect of turning off VCR cassettes
…nd Department strings. Fixing this
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/SafeNavigationConsistency found in /home/linte...
Warning: unrecognized cop Lint/SafeNavigationConsistency found in /home/linters/app/.rubocop.yml Warning: unrecognized cop Rails/ReflectionClassName found in /home/linters/app/.rubocop.yml Warning: unrecognized parameter Rails/SkipsModelValidations:Whitelist found in /home/linters/app/.rubocop.yml An error occurred while Rails/HttpStatus cop was inspecting app/controllers/catalog_controller.rb:26:4. To see the complete backtrace run rubocop -d. An error occurred while Rails/HttpStatus cop was inspecting app/controllers/catalog_controller.rb:33:4.2 errors occurred:
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/bbatsov/rubocop/issues
Mention the following information in the issue report:
0.54.0 (using Parser 2.5.1.2, running on ruby 2.6.1 x86_64-linux)
Inspecting 1 file
.
1 file inspected, no offenses detected
|
Could you clean up the commits before we merge? |
|
@dunn What do you mean by clean up? Squash the commits into one? |
|
Not all of them, but yeah. I was thinking an interactive rebase to group together commits into chunks that make sense https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#_changing_multiple |
|
@dunn Thanks for the suggestion. The commits make sense to me as they are. |
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/SafeNavigationConsistency found in /home/linte...
Warning: unrecognized cop Lint/SafeNavigationConsistency found in /home/linters/app/.rubocop.yml Warning: unrecognized cop Rails/ReflectionClassName found in /home/linters/app/.rubocop.yml Warning: unrecognized parameter Rails/SkipsModelValidations:Whitelist found in /home/linters/app/.rubocop.yml An error occurred while Rails/HttpStatus cop was inspecting app/controllers/catalog_controller.rb:26:4. To see the complete backtrace run rubocop -d. An error occurred while Rails/HttpStatus cop was inspecting app/controllers/catalog_controller.rb:33:4.2 errors occurred:
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/bbatsov/rubocop/issues
Mention the following information in the issue report:
0.54.0 (using Parser 2.5.1.2, running on ruby 2.6.1 x86_64-linux)
Inspecting 1 file
.
1 file inspected, no offenses detected
Use the right RDF URI syntax for form_of_work
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/SafeNavigationConsistency found in /home/linte...
Warning: unrecognized cop Lint/SafeNavigationConsistency found in /home/linters/app/.rubocop.yml Warning: unrecognized cop Rails/ReflectionClassName found in /home/linters/app/.rubocop.yml Warning: unrecognized parameter Rails/SkipsModelValidations:Whitelist found in /home/linters/app/.rubocop.yml An error occurred while Rails/HttpStatus cop was inspecting app/controllers/catalog_controller.rb:26:4. To see the complete backtrace run rubocop -d. An error occurred while Rails/HttpStatus cop was inspecting app/controllers/catalog_controller.rb:33:4.2 errors occurred:
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/bbatsov/rubocop/issues
Mention the following information in the issue report:
0.54.0 (using Parser 2.5.1.2, running on ruby 2.6.1 x86_64-linux)
Inspecting 1 file
.
1 file inspected, no offenses detected
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/SafeNavigationConsistency found in /home/linte...
Warning: unrecognized cop Lint/SafeNavigationConsistency found in /home/linters/app/.rubocop.yml Warning: unrecognized cop Rails/ReflectionClassName found in /home/linters/app/.rubocop.yml Warning: unrecognized parameter Rails/SkipsModelValidations:Whitelist found in /home/linters/app/.rubocop.yml An error occurred while Rails/HttpStatus cop was inspecting app/controllers/catalog_controller.rb:26:4. To see the complete backtrace run rubocop -d. An error occurred while Rails/HttpStatus cop was inspecting app/controllers/catalog_controller.rb:33:4.2 errors occurred:
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/bbatsov/rubocop/issues
Mention the following information in the issue report:
0.54.0 (using Parser 2.5.1.2, running on ruby 2.6.1 x86_64-linux)
Inspecting 1 file
.
1 file inspected, no offenses detected
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/SafeNavigationConsistency found in /home/linte...
Warning: unrecognized cop Lint/SafeNavigationConsistency found in /home/linters/app/.rubocop.yml Warning: unrecognized cop Rails/ReflectionClassName found in /home/linters/app/.rubocop.yml Warning: unrecognized parameter Rails/SkipsModelValidations:Whitelist found in /home/linters/app/.rubocop.yml An error occurred while Rails/HttpStatus cop was inspecting app/controllers/catalog_controller.rb:26:4. To see the complete backtrace run rubocop -d. An error occurred while Rails/HttpStatus cop was inspecting app/controllers/catalog_controller.rb:33:4.2 errors occurred:
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/bbatsov/rubocop/issues
Mention the following information in the issue report:
0.54.0 (using Parser 2.5.1.2, running on ruby 2.6.1 x86_64-linux)
Inspecting 1 file
.
1 file inspected, no offenses detected
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Lint/SafeNavigationConsistency found in /home/linte...
Warning: unrecognized cop Lint/SafeNavigationConsistency found in /home/linters/app/.rubocop.yml Warning: unrecognized cop Rails/ReflectionClassName found in /home/linters/app/.rubocop.yml Warning: unrecognized parameter Rails/SkipsModelValidations:Whitelist found in /home/linters/app/.rubocop.yml An error occurred while Rails/HttpStatus cop was inspecting app/controllers/catalog_controller.rb:26:4. To see the complete backtrace run rubocop -d. An error occurred while Rails/HttpStatus cop was inspecting app/controllers/catalog_controller.rb:33:4.2 errors occurred:
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/bbatsov/rubocop/issues
Mention the following information in the issue report:
0.54.0 (using Parser 2.5.1.2, running on ruby 2.6.1 x86_64-linux)
Inspecting 1 file
.
1 file inspected, no offenses detected
|
|
||
| it "collects ETD extent" do | ||
| expect(metadata_attribs[:extent]) | ||
| .to eq(["420 pages"]) |
There was a problem hiding this comment.
Layout/MultilineMethodCallIndentation: Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
Summary