Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17760 - improved the Norwegian lang file #17778

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

engern
Copy link
Contributor

@engern engern commented Dec 11, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes: #17760

Description

  1. Select Norwegian language in the backoffice.
  2. Verify that more text elements have Norwegain translation.

Copy link

github-actions bot commented Dec 11, 2024

Hi there @engern, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@engern engern changed the title 17760 - improved the norwegain lang file 17760 - improved the Norwegian lang file Dec 11, 2024
@Matthew-Wise
Copy link
Contributor

Thanks for the PR @engern Always great to see better language support. One of the Pull Request team will review it shortly :)

Although I might need a dictionary :D

Matt

@georgebid georgebid self-assigned this Dec 20, 2024
@madsrasmussen madsrasmussen self-assigned this Jan 15, 2025
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) January 20, 2025 08:51
@nielslyngsoe nielslyngsoe merged commit 87916eb into umbraco:contrib Jan 20, 2025
29 checks passed
@engern engern deleted the temp/17760 branch January 20, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Norwegian lang file
5 participants