Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: WinUI Packaged Window Title #325

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: WinUI Packaged Window Title #325

merged 1 commit into from
Jan 16, 2025

Conversation

ajpinedam
Copy link
Contributor

@ajpinedam ajpinedam commented Jan 15, 2025 •
edited
Loading

Fixes: #307

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

WinUI Window title shows "WinUI Dekstop"

What is the new behavior?

Set the correct Window title regardless of whether it is Packaged or not.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@ajpinedam ajpinedam requested a review from jeromelaban January 15, 2025 05:09
@ajpinedam ajpinedam self-assigned this Jan 15, 2025
@ajpinedam
Copy link
Contributor Author

Pre Fix Post FIx
winui_title_pre winui_title_post

@ajpinedam ajpinedam merged commit 79cb5f7 into main Jan 16, 2025
15 checks passed
@ajpinedam ajpinedam deleted the fix/wui.window.title branch January 16, 2025 04:37
@ajpinedam ajpinedam linked an issue Jan 17, 2025 that may be closed by this pull request
WinUI Desktop title is shown #307
Closed
@ajpinedam ajpinedam mentioned this pull request Jan 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees

@ajpinedam ajpinedam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WinUI Desktop title is shown
2 participants
@ajpinedam @jeromelaban