Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pivotal] Import deadline for Pivotal releases #60

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

semperos
Copy link
Member

(This PR is based on the feature branch for #59 with the expectation that that will be merged first and this PR will then target main).

From the primary commit message:

Pivotal's export includes a Deadline entry for Pivotal Releases. This
importer was already importing releases as Shortcut stories, setting
their Shortcut story type to "chore", and labelling them as a
release. This commit ensures the deadline field is also imported and
set as the Shortcut Story's deadline.

Note that Shortcut stories of any type can have a deadline set, not
just releases, but Pivotal supports deadlines only on releases.

Pivotal's export includes a Deadline entry for Pivotal Releases. This
importer was already importing releases as Shortcut stories, setting
their Shortcut story type to "chore", and labelling them as a
release. This commit ensures the deadline field is also imported and
set as the Shortcut Story's deadline.

Note that Shortcut stories of any type can have a deadline set, not
just releases, but Pivotal supports deadlines only on releases.
@semperos semperos requested a review from opoku as a code owner April 12, 2024 17:37
Copy link
Contributor

@cdemwell cdemwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from daniel/sc-264702/shortcut-team-per-import-run to main April 12, 2024 18:33
@semperos semperos merged commit 01af97b into main Apr 12, 2024
2 checks passed
@semperos semperos deleted the daniel/sc-264969/import-deadline-for-release-stories branch April 12, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants