Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site - What's new: Update post preview structure and styles #2979
USWDS-Site - What's new: Update post preview structure and styles #2979
Changes from 14 commits
647be14
0e83a74
c77ea37
7b360a4
ca4c58f
3eebc4f
4858824
3abcf7b
ecadaf6
95b14b6
80e627a
f9ccd69
f659984
39e8f6a
c0774a6
41fd023
c4d016a
55d9f08
fece742
cca2c85
0a1b612
e9f2d18
2b25d81
61aaf20
a4a2f63
11d17df
94ce244
e6a115f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Developers: I separated out the post excerpt/preview part of this file into
post-preview.html
. I did that because it felt like the structure of the markup was different enough to warrant separate files, and I also was finding it difficult to easily read the code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Much cleaner template, nice work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to say the same thing! Great work here Amy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Moved the styles from the utility classes into
uswds-theme-custom-styles
for easier style and markup management.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quibble: Feels confusing to say we're sunsetting it and then send them to the V1 site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi James, we'd linked to it in previous newsletters and monthly calls - to give users an opportunity to review and let us know if there were things they wanted to keep. Is there anywhere you can recommend we guide them instead? @amyleadem I'm also wondering if there might be instances where we don't link to anything from an announcement...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is an interesting thing to consider and definitely worth discussing.
I can code in an option that would let us turn off the link in the header. Here is a preview of what this post would look like without a header link:
Let me know if you want me to include this as an option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I do, for discussion. And I'm wondering about this post - as it ages and we take down that site, we'll need to remove that link, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A potentially new use case worth discussing. FWIW, I don't see this question as a blocker for this PR.