-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site - What's new: Create posts_short directory and add new items #3064
base: main
Are you sure you want to change the base?
Conversation
Added October Accessibility discussion update.
Added update about sunsetting 1.0
Adding November accessibility discussion blurb
Added november 3.10.0 release blurb
Added blurb about Figma design kit beta
Added November monthly call blurb
added tag so it will appear
Added tag so it'll display on the page
Added tag so it'll display on the page
Added tag so it'll display on the page
corrected my markup on tags
corrected my markup on tags
Corrected markup on tags
corrected tags markup
Added tag so it'll display on the page
Added tag so it'll display on the page
Added tag so it'll display on the page
…atsNew-24updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally everything looks good. Added some suggestions.
From the description, it wasn't immediately clear what this meant:
“Turned on the ability for "post previews" to not have a link in the header.”
What's the default behavior? What use case is this for? Is there an example?
_config.yml
Outdated
post_previews: | ||
output: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
polish: It'd be nice to name this something more accurate. It could be easily misinterpreted and potentially confusing with post_previews
. It's a short news update or blurb, not a post preview because there is no post.
Possible ideas
- post_short
- post_blurb
- update
- note
- quick_post
- post_quick
(Open to other ideas)
Co-authored-by: James Mejia <james.mejia@gsa.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me!
- News feed contains both
posts
andposts-short
content - Blank pages are not generated for
posts-short
content - Pages are appropriately generated for
posts
content - Approach taken is logical and matches code standards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me in preview like the post test item is still linking to a page. I don't think the intended change is working. I'm not sure where to comment in the code lines.
Co-authored-by: James Mejia <james.mejia@gsa.gov>
@finekatie This is actually the expected behavior because that test is coming from the "posts" directory rather than the "posts_short" directory. Anything added to the "posts" directory will generate a related page, whereas the items in "posts_short" should only generate a preview for the news feed and NOT generate a page. I'll make sure the READMEs are clear on this in #3047 |
…ats-new-directory-change
Note There is a new html-proofer build error. I will work on building a fix in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified changes and resolved comments. Thanks @amyleadem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! Great work, Amy and team!
Summary
_/posts_short
directory to the site and moved all "what's new" content that did not have an attached post to this directory._posts_short
will be integrated with the items inside_posts
in the "What's new" feed.Important
The build failures in this PR should be fixed by #3088
Related PR
Note
This PR is a replacement for #3056, which did not include any technical work and just added new content to the "what's new" page. However, we realized additional dev work was needed to get these items to build correctly. This PR incorporates both the new content and the technical fixes.
Related issue
Closes #2989
The README instructions for creating posts and post-previews will be added in #3047.
Preview link
Problem statement
Outdated content on what's new page
What's new page is out of date after recent page merge and reworking how content can be added. Need new news items added.
Post previews added to _posts generated empty pages
Adding preview-only items to the
/_posts
directory caused the site to build empty posts, which is unnecessary and bad for SEO.Solution
Outdated content on what's new page
Blurbs were written up for events from October and November, reviewed and approved with feds and posts were created.
Post previews added to _posts generated empty pages
We created a separate collection for
/_posts_short
and set theoutput
for this collection tofalse
. This means that no pages will be generated for these files.Anatomy of a short post
Example data structure for short posts with a link
Example data structure for short posts without a link
Testing and review
Content
Devs
/_posts
and/_post-previews
in the expected sort order/_post-previews
output: false
tooutput:true
in _config.yml in your local build, you should no longer get a 404 for that url./_posts