Report more warnings, summarize job output #1996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamfidel
reviewed
Jan 9, 2025
|
|
||
| if [[ "${{ matrix.backend }}" == "dpcpp" ]]; then | ||
| make_targets="build-onedpl-sycl_iterator-tests build-onedpl-ranges-tests" | ||
| ctest_flags="-R (sycl_iterator_.*)|(std_ranges_.*)\.pass" | ||
| echo "::warning::dpcpp backend is set. Compile and run only sycl_iterator tests" |
There was a problem hiding this comment.
I believe the ::warning syntax is a workflow annotation: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-a-warning-message.
Do we want to remove these from the logs?
There was a problem hiding this comment.
It becomes unnecessary. The summary will show the number of the tests, as well as the ctest details if you expand the corresponding section.
There was a problem hiding this comment.
You can check this tab to see how it looks like.
There was a problem hiding this comment.
Do we want to remove these from the logs?
Ah, I see. Yes, let me remove it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1850, with #1994 being an additional motivator.
This PR adds
-Wall(for GCC/Clang/ICX/ICPX) and/W4(for MSVC) compiler flags to detect various warnings, such as unused variables, dangerous type conversions and other.The number of warnings is large to the extent it can be challenging to navigate through the log files. To address this, the PR also adds a summary for each CI job to simplify analysis of their outputs. The summary includes:
ctestoutput.