Add msi #58
Merged
Add msi #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abe-winter
reviewed
Jan 14, 2025
agent.msi
Outdated
abe-winter
reviewed
Jan 14, 2025
agent.wixpdb
Outdated
abe-winter
reviewed
Jan 14, 2025
Makefile
Outdated
| GOOS=windows GOARCH=amd64 go build -o $@ -trimpath -tags $(TAGS) -ldflags $(LDFLAGS) ./cmd/viam-agent | ||
| file $@ | ||
| du -hc $@ | ||
| go build -o $@ -trimpath ./cmd/viam-agent |
There was a problem hiding this comment.
$(LDFLAGS) here potentially affects file size
|
@abe-winter i kicked off a workflow using the latest of my PR and here's the artifact https://github.com/viamrobotics/agent/actions/runs/12798170184 do you want try it on your laptop? |
|
works!!! deleted my existing service + my opt folder and agent + RDK came up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the workflow doesn't exist in the main branch, we can't use the UI but you can use the CLI to kick of the workflow
gh workflow run build-msi.yaml --ref ap-add-msi -f msi_version=VERSION