Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back missing fields in server logs and remove double log #409

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

cheukt
Copy link
Member

@cheukt cheukt commented Jan 24, 2025

used to look like

2025-01-24T17:53:02.436Z        ERROR   rdk.networking  goutils-cheuk/logger.go:161  finished unary call with code InvalidArgument   {"error":"rpc error: code = InvalidArgument desc = host not preconfigured","grpc.code":"InvalidArgument","grpc.time_ms":0.078,"grpc.start_time":"2025-01-24T17:53:02.436Z"}

and now it looks like

2025-01-24T17:57:09.728Z        ERROR   rdk.networking  goutils-cheuk/logger.go:161  finished unary call with code InvalidArgument   {"error":"rpc error: code = InvalidArgument desc = host not preconfigured","grpc.code":"InvalidArgument","grpc.time_ms":0.091,"grpc.start_time":"2025-01-24T17:57:09.727Z","grpc.request.deadline":"2025-01-24T17:57:19.722Z","span.kind":"server","system":"grpc","grpc.service":"proto.rpc.webrtc.v1.SignalingService","grpc.method":"OptionalWebRTCConfig"}

also removed the double logs. We can consider shifting context.Canceled/io.ClosedPipe errors down to debug to mimic the existing filtering, but we can decide on that later

@viambot viambot added the safe to test Mark as safe to test label Jan 24, 2025
Copy link
Member

@bashar-515 bashar-515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@cheukt cheukt merged commit ac7a6ac into viamrobotics:main Jan 24, 2025
6 checks passed
@cheukt cheukt deleted the minor-logging-changes branch January 24, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Mark as safe to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants