RSDK-9587 generate series of waypoints to cover surface given a pcd mesh #4719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
raybjork
requested changes
Jan 16, 2025
…nts-to-cover-surface-given-a-pcd-mesh
viambot
added
safe to test
viambot
added
safe to test
nfranczak
approved these changes
Jan 27, 2025
viambot
added
safe to test
raybjork
approved these changes
Jan 27, 2025
spatialmath/triangle.go
Outdated
|
|
||
| // ClosestPointTriangleCoplanarPoint takes a point, and returns the closest point on the triangle to the given point | ||
| // The given point *MUST* be coplanar with the triangle. If it is known ahead of time that the point is coplanar, this is faster. | ||
| func ClosestPointTriangleCoplanarPoint(t *Triangle, pt r3.Vector) r3.Vector { |
There was a problem hiding this comment.
I didn't realize these triangle functions were currently unused (or at least I cant see any other references to them in this PR). Can we just move them to the rest of coverage code?
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add assorted public methods associated with Triangles and Meshes.
Also adds several helpful debug statements.