improve rimage package ergonomics #4734
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
raybjork
commented
Jan 21, 2025
| px, py, pz := pci.PixelToPoint(float64(pt.X), float64(pt.Y), float64(d)) | ||
| return r3.Vector{px, py, pz}, nil | ||
| return r3.Vector{px, py, pz} |
There was a problem hiding this comment.
This change can be bubbled up further but ultimately ends up changing a public interface so didn't want to make that change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is going to end up being a catch all for improvements I find while using it. Going to leave it in draft form until I finish the project I'm working on