Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-7497: Add Button client, server, and fake model #4740

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ethanlookpotts
Copy link
Member

@ethanlookpotts ethanlookpotts commented Jan 24, 2025

This adds the button client and server, and registers a button fake model.

Here's a button component properly configured in app:
image

  1. APP-7497: Add Button and Switch APIs api#619
  2. APP-7497: Add Button client, server, and fake model #4740
  3. APP-7497: Add Switch client, server, and fake models #4741

Change log

I used Cursor quite a bit here:

  • Add Button SDK helpers
  • Add client and tests
  • Add server and tests
  • Add inject testutil
  • Add fake button implementation and register it
    • This implementation just logs a message when pushed

Review requests

  • Code review
  • Try a config with the button fake - does it work as expected?

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jan 24, 2025
@ethanlookpotts ethanlookpotts force-pushed the APP-7497/ethanlookpotts/button branch from 87741a8 to 6b4f06f Compare January 24, 2025 18:50
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants